Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: add causes to applicable webcrypto's OperationError #44890

Merged
merged 1 commit into from
Oct 10, 2022
Merged

crypto: add causes to applicable webcrypto's OperationError #44890

merged 1 commit into from
Oct 10, 2022

Conversation

panva
Copy link
Member

@panva panva commented Oct 4, 2022

Builds on top of #44703, adding the underlying error as cause to WebCryptoAPI DOMExceptions.

@panva panva added crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. webcrypto labels Oct 4, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 4, 2022
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2022
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 4, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Oct 5, 2022
Open
19 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47076/

anonrig
anonrig reviewed Oct 5, 2022
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

This was referenced Oct 6, 2022
Open
Open
Open
Open
Open
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2022
@nodejs-github-bot nodejs-github-bot merged commit 0d80e73 into nodejs:main Oct 10, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 0d80e73

danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@panva @danielleadams
crypto: add causes to applicable webcrypto's OperationError
99a2c16 
PR-URL: #44890
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
Merged
@panva panva deleted the add-webcrypto-causes branch October 13, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig left review comments

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@panva @nodejs-github-bot @lpinca @anonrig @aduh95